Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update some of our readme files #991

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

cyli
Copy link
Contributor

@cyli cyli commented Oct 4, 2016

  • Added new features in master that are not in 0.4.2 to the changelog for the next release
  • Updated the README and CONTRIBUTING doc to reflect the fact that master is our development branch.

Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this up to speed. Non-blocking: we should add some info somewhere about the use of gitflow in managing releases

@cyli cyli force-pushed the doc-fixes-and-wip-changelog branch from d4522f4 to fb56614 Compare October 4, 2016 23:59
@cyli
Copy link
Contributor Author

cyli commented Oct 5, 2016

@endophage Good idea, updated the CONTRIBUTING.md doc to specifically mention it.
I don't really have any more detailed instructions on how to set up git flow however, since I've clearly done it wrong over and over :D

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits, thank you for updating these!

+ PostgresSQL support as a storage backend for Server and Signer [#920](https://github.com/docker/notary/pull/920)
+ Notary server's health check now fails if it cannot connect to the signer, since no new repositories can be created and existing repositories cannot be updated if the server cannot reach the signer [#952](https://github.com/docker/notary/pull/952)
+ Server runs its connectivity healthcheck to the server once every 10 seconds instead of once every minute. [#902](https://github.com/docker/notary/pull/902)
+ The keys on disk are now stored in the `~/.notary/private` directory, rather than in a key hierarchy that separates them by GUN and by role. Notary will automatically migrate old-style directory layouts to the new style. **This is not forwards-compatible against notary<0.4.1 and docker<=1.12** [#872](https://github.com/docker/notary/pull/872)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: notary<0.4.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... 0.4.1 does have the relevant change, and it is tagged. But it is also not released. I think 0.4.1 is technically more correct, but 0.4.2 is more friendly. Will be happy to make the change if you feel it'd be better

Copy link
Contributor Author

@cyli cyli Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, nm, I'm just going to make the change. They should just probably be using 0.4.2. :) Thanks and sorry for the indecisiveness

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I agree that 0.4.2 might be a little easier to understand since it's our latest release.

## [v0.4.1](https://github.com/docker/notary/releases/tag/v0.4.0) 9/27/2016
## v0.5-dev (in progress)
+ Non-certificate public keys in PEM format can now be added to delegation roles [#965](https://github.com/docker/notary/pull/965)
+ PostgresSQL support as a storage backend for Server and Signer [#920](https://github.com/docker/notary/pull/920)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: PostgreSQL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

… and CONTRIBUTING with info about our release process.

Signed-off-by: Ying Li <ying.li@docker.com>
@cyli cyli force-pushed the doc-fixes-and-wip-changelog branch from fb56614 to c440dbc Compare October 5, 2016 05:49
@riyazdf riyazdf merged commit cd8295a into notaryproject:master Oct 5, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants