🐛 Ease how we determine preprocessed location #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
approved these changes
Nov 28, 2023
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world. With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone. Note: sniffing out where this file exists in SpaceStone is a very fragile process. Closes #289 Related to: - #289
jeremyf
force-pushed
the
ease-preprocess-location-determination
branch
from
64fe854 to
39f57c4
Compare
|
Favor #305 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we assumed the ancestor must have an AARK_ID. However that is not always the case. Which is confounding given the data structure of the files; however such is the way of the world.
With this commit we fallback to the file_set's internal information to attempt to find the file in the preprocessed location. Namely if the FileSet had an import_url, we'll use that to derive where it probably went in SpaceStone.
Note: sniffing out where this file exists in SpaceStone is a very fragile process.
Closes #289
Related to: