🎁 Add listener for handling file set attachment #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why a listener and not a transaction? In part because the moment I want to perform the conditional enqueuing is at the point where the `Hyrax::WorkUploadsHandler` does it's job. That is when we have: - the parent work - the file set - the original file - the user The `Hyrax::WorkUploadsHandler` is most analogous to the behavior in `Hyrax::Actors::FileSetActor#attach_to_work` and `Hyrax::Actors::FileSetActor#create_content`. Fortunately, Hyrax's transaction and upload handler remove the conditional handling we needed between uploading a remote file and directly uploading a file. Related to: - notch8/hykuup_knapsack#35 - notch8/hykuup_knapsack#99 - #312
jeremyf
force-pushed
the
add-listener-for-file-set-attach
branch
from
fdbb925 to
a0ea1de
Compare
kirkkwang
approved these changes
Jan 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why a listener and not a transaction? In part because the moment I want
to perform the conditional enqueuing is at the point where the
Hyrax::WorkUploadsHandlerdoes it's job. That is when we have:The
Hyrax::WorkUploadsHandleris most analogous to the behavior inHyrax::Actors::FileSetActor#attach_to_workandHyrax::Actors::FileSetActor#create_content. Fortunately, Hyrax'stransaction and upload handler remove the conditional handling we needed
between uploading a remote file and directly uploading a file.
Related to: