Fix advisory #652
Merged
Fix advisory #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you please add a changelog entry: ## notify-types 2.0.0 (unreleased)
- CHANGE: replace instant crate with web-time **breaking** |
|
Just calling out that |
|
@bushrat011899 Thanks for the info. But I don't see an issue with MIT/Apache-2.0. |
|
@bushrat011899 Is there a Bevy issue related to this? |
|
@dfaust no @BenjaminBrienen just noticed it and let us know on the Discord. They're very quick with this stuff haha. |
|
@dfaust done! let me know if it is in the wrong spot or something. |
|
Thanks |
zydou
pushed a commit
to zydou/arti
that referenced
this pull request
Nov 12, 2024
We depend on `instant`, which is unmaintained, via `notify`. `notify` switched over to [`web-time`], but hasn't relased the change yet, so we need to ignore the advisory for now. [`web-time`]: notify-rs/notify#652
1 task
|
@dfaust can this be released ( |
|
notify-8.0.0 has just been released! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a security advisory.
instantis no longer maintained, but there is a drop-in replacement.