Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

notodiff: png image is not wide enough #315

Closed
marekjez86 opened this issue Nov 14, 2016 · 5 comments · Fixed by #319
Closed

notodiff: png image is not wide enough #315

marekjez86 opened this issue Nov 14, 2016 · 5 comments · Fixed by #319

Comments

@marekjez86
Copy link
Contributor

I'm not sure how we decide on how wide the diffed image should be.
Here's the input (left --before; right --after)
before-after

the diff image is missing significant information (IMHO)
jv__d_dha__pas

@jamesgk
Copy link
Contributor

jamesgk commented Nov 16, 2016

What font is this?

@marekjez86
Copy link
Contributor Author

@jamesgk
Copy link
Contributor

jamesgk commented Nov 17, 2016

Which glyph's image did you attach? I don't see any notodiff output quite like that.

@marekjez86
Copy link
Contributor Author

--before NotoSansJavanese-Regular.ttf.zip
--after NotoSansJavanese-Regular-c.ttf.zip

look for jv__d_dha__pas

@jamesgk
Copy link
Contributor

jamesgk commented Nov 17, 2016

Huh, when I run notodiff on those two fonts I get
Mark class mismatch for jv_Ddha_pas (no class vs mark)
and no jv__d_dha__pas.png is generated.

I should have a fix soon for rendering widths anyways, but it's strange that we'd see different things here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants