notodiff fixes #319
Merged
notodiff fixes #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 21, 2016 11:04
Before this would pad with more than one space than necessary when the width of the spaces just matched the width of the padded glyph.
dougfelt
reviewed
Nov 21, 2016
| @@ -109,7 +121,14 @@ def input_from_name(self, name, features=(), seen=None, pad=False): | |||
| # recursive calls that it makes might have themselves returned None, | |||
| # but we should avoid returning None here if there are other options | |||
| inputs = [i for i in inputs if i is not None] | |||
There was a problem hiding this comment.
or filter(None, inputs)? I guess not if i is a type that can be not None yet still convert to False
There was a problem hiding this comment.
Actually the reason why I avoid using filter is that it behaves differently between python 2 and 3 (where it returns a filter object). For example bool(filter(None, [0])) is False in python 2 but True in python 3. Not an issue (yet) for nototools but still something I like to avoid.
dougfelt
approved these changes
Nov 21, 2016
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #315