Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: add send method #67

Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat: add send method #67

merged 1 commit into from
Jan 24, 2025

Conversation

notrab
Copy link
Owner

@notrab notrab commented Oct 27, 2024

@rayblair06 this could help with what you were describing on Discord. Lmkwyt

@rayblair06
Copy link
Contributor

I like the idea of a send function. Just my $0.02 but not sure I'm totally sold on passing $contentType and $headers parameters. Not sure if it might cause some confusing or introduce edgecases where developers will pass both Content-Type headers via parameters for $contentType and $headers.

@notrab notrab merged commit d79c08e into main Jan 24, 2025
1 check passed
@notrab notrab deleted the send-method branch January 24, 2025 16:35
@notrab
Copy link
Owner Author

notrab commented Jan 24, 2025

@rayblair06 I merged as is as someone was asking me about this, and didn't have the headspace to get back into it fully.

Happy to make some changes to this later, and most of all, Dumbo in general.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notrab @rayblair06