registry-next configuration enhancements #14
Assignees
Comments
|
Yeah! It would be great! Seems in current stable (https://github.com/dotcloud/docker-registry/tree/0.7.3) list value in |
noxiouz
added a commit
that referenced
this issue
Aug 13, 2014
noxiouz
added a commit
that referenced
this issue
Aug 13, 2014
|
That was fast :-) |
|
Yeaah! :-) |
pyotr777
pushed a commit
to pyotr777/docker-registry-driver-git
that referenced
this issue
Feb 25, 2015
docker-registry has a local database which can be queried using a simple
REST API. If you trash this database, it is supposed to be recreated
when you restart docker-registry. This fix the recreation of the db which
happens thanks to results of the the list_directory function. Previously
this was empty.
To test the problem and review the solution:
1. assuming a working swift and docker registry with swift driver installed;
2. push some images;
3. stop docker-registry;
4. check sqlalchemy_index_database in docker registry conf and "rm" the database (by default a sqlite file);
5. restart docker-registry;
With the old code the database will be empty. With the new one the db
will be filled with the already pushed images. The main problem come
from the facts that:
$ curl -i -X GET -H "X-Auth-Token: AUTH_token" 'http://localhost:8080/v1/AUTH_test/docker?prefix=lvl_1/&delimiter=/&format=json'
[{"hash": "a83a7dcf68a3dd1d83584abd8e230829", "last_modified": "2014-09-17T15:26:25.585390", "bytes": 29, "name": "lvl_1/file_2", "content_type": "application/octet-stream"}, {"subdir": "lvl_1/lvl_2/"}]
and
$ curl -i -X GET -H "X-Auth-Token: AUTH_token" 'http://localhost:8080/v1/AUTH_test/docker?path=lvl_1/&format=json'
[{"hash": "a83a7dcf68a3dd1d83584abd8e230829", "last_modified": "2014-09-17T15:26:25.585390", "bytes": 29, "name": "lvl_1/file_2", "content_type": "application/octet-stream"}]
do not return the same thing. The main difference being that the
subdirectories are not return when using the "path" syntax.
I tested with swift 1.8.0 and check that the Pseudo-hierarchical folders
and directories behaviour was the same on swift 2.2.0.
This would close noxiouz#14 and noxiouz#15. The "fill it if not there" mechanism is
described in this issue docker-archive/docker-registry#516
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Hey there :-)
Have a look here:
docker-archive/docker-registry#444
How does this concern you?
myvar = cfg.get(key, DEFAULT)no longer exist - just replace these calls withmyvar = cfg.key or DEFAULTfor the same effectThis will likely get released with registry 0.8 by the end of the month.
These changes are breaking drivers, so I decided to bump the core version (2.0.0) to ease the transition (though nothing in core really changed): just up your dependency to the core and you should be done.
I encourage you to mention the change as well in your README, so that people looking for a 0.7 compatible release can pip install an old version of your driver (or you decide maintaining 0.7 compatibility is not worth it and drop it).
Hope that helps!
Cheers.
The text was updated successfully, but these errors were encountered: