fix: attach a catch handler to the handleContentP promise

[kalinkrustev]

This attaches a catch handler to the handleContentP promise, as in some cases the flush is not called before node decides that this is an unhandled promise rejection.

Fixes #249

[wraithgar]

Ah good catch. It looks like the thing that is throwing is

cacache/lib/content/write.js

Line 103 in 2e1383d

const tmp = await makeTmp(cache, opts)

If that were to be brought inside the try/catch block, and then this line

cacache/lib/content/write.js

Line 114 in 2e1383d

if (!tmp.moved) {

Changed to

if (!tmp?.moved) {

We wouldn't need the catch.

[wraithgar]

There is an error handler set up on the promise at

cacache/lib/content/write.js

Line 92 in 2e1383d

(er) => cb(er)

But it only happens during flush, way too late.

[wraithgar]

this.destroy seems to be overreaching in scope. I think we want cb(error)

We can also attach it directly to the function call handleContent().catch()

[kalinkrustev]

Unfortunately this does not help.

[kalinkrustev]

this.destroy seems to be overreaching in scope

Yes, I changed it to emit the error instead. Seems to work and does not break the test coverage.

[kalinkrustev]

We wouldn't need the catch.

Why? It will still be a rejected promise. It is currently a try...finally block. If it is changed to try...catch, the error should still go somewhere. And it could be also error coming from pipeToTmp or moveToDestination.

[wraithgar]

Looks good w/ just the simple .catch added. Were you able to test this against your example in #249?

[kalinkrustev]

Yes, I tested it and it works fine.