allow deletions of indexes, handle null integrity values in compact better #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
approved these changes
May 25, 2021
|
|
||
| If `opts.validateEntry` is not provided, however, every entry in the index will | ||
| be deduplicated and kept until the first `null` integrity is reached, removing | ||
| all entries that were written before the `null`. |
There was a problem hiding this comment.
So, if I'm reading this correctly, adding a null index entry and then a new index entry, then compacting is somewhat the same as doing removeAll and then adding the new one? Like, the null means "ignore all that came before"?
| // entries come first in order to make looping through them easier | ||
| // the true passed to formatEntry tells it to keep null | ||
| // integrity values, if they made it this far it's because | ||
| // the user specified a metadata field in keepMissingIntegrityWhenSet |
There was a problem hiding this comment.
Is keepMissingIntegrityWhenSet still a thing? I thought the caller just provides their own validateEntry function to do that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this provides an option to
cacache.rm/cacache.rm.entrythat allows a user to indicate they wish for the entire index file to be removed rather than appending a new entry with an integrity ofnull. this is how make-fetch-happen will invalidate the cache for a given URLit also enhances
cacache.index.compactto accept avalidateEntryoption that allows a user to keep entries withnullintegrities, so long as they are considered valid. this is how make-fetch-happen will keep index entries that have anullintegrity (redirect responses have no body) and still be able to prune out older entries with a null integrity.References
Related to npm/make-fetch-happen#49