Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Add s390x arch support #1455

Closed
guimard opened this issue Jun 23, 2020 · 7 comments
Closed

[BUG] Add s390x arch support #1455

guimard opened this issue Jun 23, 2020 · 7 comments
Labels
Bug thing that needs fixing Release 6.x work is associated with a specific npm 6 release

Comments

@guimard
Copy link

guimard commented Jun 23, 2020

What / Why

Hi,

after some test, s390x is well supported excepted in listed test:

--- a/test/tap/legacy-platform-all.js
+++ b/test/tap/legacy-platform-all.js
@@ -36,6 +36,7 @@
         'arm64',
         'mips',
         'ia32',
+        's390x',
         'x64',
         'sparc'
       ]
@guimard
Copy link
Author

guimard commented Jun 23, 2020

When running tests on a s390x machine, I found this kind of errors:

Error: Failed to replace env in config: ${prefix}
    at /home/yadd/cli-6.14.5/lib/config/core.js:415:13
    at String.replace (<anonymous>)
    at envReplace (/home/yadd/cli-6.14.5/lib/config/core.js:411:12)
    at parseField (/home/yadd/cli-6.14.5/lib/config/core.js:389:7)
    at /home/yadd/cli-6.14.5/lib/config/core.js:330:24
    at Array.forEach (<anonymous>)
    at Conf.add (/home/yadd/cli-6.14.5/lib/config/core.js:328:23)
    at ConfigChain.addString (/home/yadd/cli-6.14.5/node_modules/config-chain/index.js:244:8)
    at Conf.<anonymous> (/home/yadd/cli-6.14.5/lib/config/core.js:316:10)
    at /home/yadd/cli-6.14.5/node_modules/graceful-fs/graceful-fs.js:123:16
test/tap/00-verify-ls-ok.js ........................... 4/5

@LocutusOfBorg
Copy link
Contributor

shouldn't we also add ppc64el?

@guimard
Copy link
Author

guimard commented Jul 12, 2020

Sadly ppc64el gives the same kind of errors

@guimard
Copy link
Author

guimard commented Sep 1, 2020

Hi, it looks like it was a Debian/Node.js issue. npm works fine with s390x, ppc64 and ppc64el

@ljharb
Copy link
Contributor

ljharb commented Sep 1, 2020

Make sure npm isn’t installed separately, npm only ships with node.

@guimard
Copy link
Author

guimard commented Sep 1, 2020

@ljharb: sure

@darcyclarke darcyclarke added Release 6.x work is associated with a specific npm 6 release Bug thing that needs fixing labels Oct 30, 2020
darcyclarke pushed a commit that referenced this issue Jan 8, 2021
@darcyclarke
Copy link
Contributor

npm v6 is no longer in active development; We will continue to push security releases to v6 at our team's discretion as-per our Support Policy.

If your bug is preproducible on v7, please re-file this issue using our new issue template.

If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo

Closing: This is an automated message.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug thing that needs fixing Release 6.x work is associated with a specific npm 6 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants