Skip to content

[BUG] unexpected change in behavior of npm view --json of invalid version of a package #1639

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
MylesBorins opened this issue Aug 7, 2020 · 3 comments
Closed

[BUG] unexpected change in behavior of npm view --json of invalid version of a package #1639

MylesBorins opened this issue Aug 7, 2020 · 3 comments
Assignees
@darcyclarke
Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Milestone
OSS - Sprint 14

Comments

@MylesBorins
Copy link
Contributor

Current Behavior:

$ npm view --json lodash@0.0.0
undefined
$

Expected Behavior:

In previous versions of npm there would be no content returned

$ npm view --json lodash@0.0.0
$

Steps To Reproduce:

Run above commands

Environment:

OSX 10.15.6
Node.js v14.6.0
npm v7.0.0-beta.2
@MylesBorins MylesBorins added Release 7.x work is associated with a specific npm 7 release Bug thing that needs fixing Needs Triage needs review for next steps labels Aug 7, 2020
@darcyclarke darcyclarke removed the Needs Triage needs review for next steps label Aug 10, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 13 milestone Aug 10, 2020
@darcyclarke
Copy link
Contributor

This should be addressed when we land: #1657

@claudiahdz claudiahdz mentioned this issue Aug 14, 2020
Closed
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Sep 1, 2020 •
edited
Loading

This has not been entirely fixed

npm v6.x output

[~]$ npm view --json lodash@0.0.0
[~]$

npm 7.x output

[~]$ npm view --json lodash@0.0.0

[~]$

Notice the additional newline that we have now. This is probably a non issue for most cases but it did break some internals on CITGM (but were patched easily enough)

@darcyclarke darcyclarke assigned darcyclarke and unassigned claudiahdz Sep 3, 2020
MylesBorins added a commit to MylesBorins/cli that referenced this issue Sep 10, 2020
@MylesBorins
view: directly print to process.stdout
6cde6e7 
Currently in npm 7 output of npm view is being printed
by a call to console.log which is causing an extra newline
on output compared to npm 6. Replace the call to console.log
with process.stdout.write to avoid this.

Fixes: npm#1639
MylesBorins added a commit to MylesBorins/cli that referenced this issue Sep 10, 2020
@MylesBorins
view: directly print to process.stdout
fa98d86 
Currently in npm 7 output of npm view is being printed
by a call to console.log which is causing an extra newline
on output compared to npm 6. Replace the call to console.log
with process.stdout.write to avoid this.

Fixes: npm#1639
MylesBorins added a commit to MylesBorins/cli that referenced this issue Sep 10, 2020
@MylesBorins
view: directly print to process.stdout
8e480b8 
Currently in npm 7 output of npm view is being printed
by a call to console.log which is causing an extra newline
on output compared to npm 6. Replace the call to console.log
with process.stdout.write to avoid this.

Fixes: npm#1639
@MylesBorins MylesBorins mentioned this issue Sep 10, 2020
Closed
ruyadorno pushed a commit that referenced this issue Sep 16, 2020
@MylesBorins @ruyadorno
fix: npm view should not output extra newline
63005f4 
Currently in npm 7 output of npm view is being printed
by a call to console.log which is causing an extra newline
on output compared to npm 6. Replace the call to console.log
with process.stdout.write to avoid this.

Fixes: #1639

PR-URL: #1791
Credit: @MylesBorins
Close: #1791
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno mentioned this issue Sep 16, 2020
Merged
@ruyadorno
Copy link
Contributor

landed in v7.0.0-beta.11

@Omrisnyk Omrisnyk mentioned this issue Nov 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 20, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Feb 12, 2024
Open
@Omrisnyk Omrisnyk mentioned this issue Mar 22, 2024
Open
@Omrisnyk Omrisnyk mentioned this issue May 29, 2024
Open
@snyk-io snyk-io bot mentioned this issue Oct 23, 2024
Open
@Omrisnyk Omrisnyk mentioned this issue Nov 7, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@darcyclarke darcyclarke

Labels
Bug thing that needs fixing Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
OSS - Sprint 14
Development

No branches or pull requests
4 participants
@ruyadorno @darcyclarke @MylesBorins @claudiahdz