Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] npm link does not respect --no-save #3619

Closed
1 task done
ljharb opened this issue Aug 6, 2021 · 6 comments
Closed
1 task done

[BUG] npm link does not respect --no-save #3619

ljharb opened this issue Aug 6, 2021 · 6 comments
Assignees
@Santoshraj2
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 7.x work is associated with a specific npm 7 release Release 8.x work is associated with a specific npm 8 release Release 9.x work is associated with a specific npm 9 release

Comments

@ljharb
Copy link
Contributor

ljharb commented Aug 6, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

npm link --no-save $something

updates package.json with a file:// link.

Expected Behavior

--no-save means nothing gets saved.

Steps To Reproduce

See above.

Environment

  • OS: Mac
  • Node: 16.6.1
  • npm: v7.20.3
@ljharb ljharb added Release 7.x work is associated with a specific npm 7 release Bug thing that needs fixing Needs Triage needs review for next steps labels Aug 6, 2021
@AttractiveDog
Copy link

Try deleting cache data

@ljharb
Copy link
Contributor Author

ljharb commented Aug 7, 2021

@AttractiveDog can you explain why you think that would have any relevance to this?

@AttractiveDog
Copy link

This thing does not seem to mean anything it is just for the point where it may have stuck.

By the way it seems to be a bug

@majidkhan12
Copy link

I need it now.

@lukekarrys lukekarrys added Priority 2 secondary priority issue and removed Needs Triage needs review for next steps labels Oct 25, 2021
@ljharb ljharb mentioned this issue Dec 25, 2021
Closed
@ljharb ljharb added the Release 8.x work is associated with a specific npm 8 release label Dec 25, 2021
@ljharb
Copy link
Contributor Author

ljharb commented Dec 25, 2021 •
edited
Loading

This continues to be a problem on npm v8.3.0, and is why v19.0.3 of eslint-config-airbnb was broken last night.

If someone gives me a pointer, I'd be happy to make a PR to fix it.

ljharb added a commit to airbnb/javascript that referenced this issue Dec 25, 2021
@ljharb
[meta] revert changes from d4e39c9
34b5bc3 
Caused by npm/cli#3619
@fritzy fritzy self-assigned this Dec 7, 2022
@ljharb ljharb added the Release 9.x work is associated with a specific npm 9 release label Feb 14, 2023
@lukekarrys lukekarrys added Priority 1 high priority issue and removed Priority 2 secondary priority issue labels Feb 15, 2023
Binary-Ninja-007 added a commit to Binary-Ninja-007/JavaScript_Style_Guide that referenced this issue Aug 13, 2023
@Binary-Ninja-007
[meta] revert changes from d4e39c9b10767cc77c7d0091f2eae06a6ccfc33e
ed51745 
Caused by npm/cli#3619
harry908nilson pushed a commit to marcolane/Javascriipt that referenced this issue Sep 1, 2023
@marcolane
[meta] revert changes from d4e39c9b10767cc77c7d0091f2eae06a6ccfc33e
2fc0086 
Caused by npm/cli#3619
talentdev219 pushed a commit to talentdev219/javascript that referenced this issue Sep 17, 2023
[meta] revert changes from d4e39c9b10767cc77c7d0091f2eae06a6ccfc33e
982e14d 
Caused by npm/cli#3619
@fritzy fritzy removed their assignment Sep 27, 2023
@Santoshraj2 Santoshraj2 self-assigned this Oct 5, 2023
@Santoshraj2 Santoshraj2 mentioned this issue Oct 17, 2023
Merged
@wraithgar
Copy link
Member

Closed by #6910

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Santoshraj2 Santoshraj2

Labels
Bug thing that needs fixing Priority 1 high priority issue Release 7.x work is associated with a specific npm 7 release Release 8.x work is associated with a specific npm 8 release Release 9.x work is associated with a specific npm 9 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@wraithgar @ljharb @fritzy @lukekarrys @majidkhan12 @AttractiveDog @Santoshraj2