Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] npm fund <package> errors when "funding" is a string #498

Closed
panva opened this issue Nov 19, 2019 · 1 comment
Closed

[BUG] npm fund <package> errors when "funding" is a string #498

panva opened this issue Nov 19, 2019 · 1 comment
Assignees
@ruyadorno
Labels
Bug thing that needs fixing semver:patch semver patch level for changes

Comments

@panva
Copy link

panva commented Nov 19, 2019 •
edited
Loading

What / Why

While #472 has fixed the npm fund command not showing packages where "funding" is a string, the npm fund <package-name> command doesn't work for these.

In the screenshot below glob got opened, the other one didn't.

Screenshot 2019-11-19 10 58 59

Expected Behavior

npm fund <package> works regardless of the funding property being a shorthand string or an object.
@ljharb
Copy link
Contributor

ljharb commented Nov 19, 2019

cc @ruyadorno

@ruyadorno ruyadorno added the Bug thing that needs fixing label Nov 19, 2019
@darcyclarke darcyclarke added the semver:patch semver patch level for changes label Nov 19, 2019
ruyadorno added a commit to ruyadorno/cli that referenced this issue Nov 19, 2019
@ruyadorno
fix(fund): open url for string shorthand
c1a1d95 
Trying to open url for a package that is using the string shorthand is
currently broken using: `npm fund <pkg>`

This commit fixes the issue and adds the missing unit and integration
tests covering that usecase.

Fixes npm#498
ruyadorno added a commit that referenced this issue Nov 19, 2019
@ruyadorno
fix(fund): open url for string shorthand
23f2411 
Trying to open url for a package that is using the string shorthand is
currently broken using: `npm fund <pkg>`

This commit fixes the issue and adds the missing unit and integration
tests covering that usecase.

Fixes #498
@ruyadorno ruyadorno mentioned this issue Nov 19, 2019
Closed
@hojatA1 hojatA1 mentioned this issue Jun 23, 2023
Open
@EMWickd EMWickd mentioned this issue Jun 24, 2023
Open
@EMWickd EMWickd mentioned this issue Dec 1, 2023
Open
@Billywildhig Billywildhig mentioned this issue Dec 1, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ruyadorno ruyadorno

Labels
Bug thing that needs fixing semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ljharb @ruyadorno @panva @darcyclarke