Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: lazy loading of arborist and pacote #6225

Merged
merged 6 commits into from
Apr 18, 2023
Merged

fix: lazy loading of arborist and pacote #6225

merged 6 commits into from
Apr 18, 2023

Conversation

wraithgar
Copy link
Member

This is a test to try some very limited intentional lazy loading.
Please squash this when and if it comes time to land.

  • fix: shuffle arborist requires around
  • fix: continue shuffling arborist requires
  • fix: decouple arborist from flatoptions
  • fix: stop passing arborist to itself
  • fix: add self to options passed downstream
  • fix: lazy load pacote/chalk during updateNotifier

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Mar 6, 2023

found 4 benchmarks with statistically significant performance improvements

  • app-large: show-version, run-script
  • app-medium: show-version, run-script
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 40.275 ±1.23 18.270 ±0.15 16.928 ±0.05 19.540 ±0.85 3.205 ±0.17 3.068 ±0.04 2.364 ±0.03 11.509 ±0.06 2.379 ±0.01 3.482 ±0.00 0.501 ±0.00 0.521 ±0.01
#6225 40.039 ±2.31 18.208 ±0.12 16.684 ±0.29 20.524 ±0.79 3.166 ±0.03 3.129 ±0.09 2.404 ±0.03 11.743 ±0.04 2.452 ±0.04 3.606 ±0.12 0.362 ±0.01 0.379 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 24.397 ±1.22 13.706 ±0.04 12.770 ±0.17 14.038 ±0.18 2.755 ±0.01 2.761 ±0.09 2.396 ±0.04 8.766 ±0.04 2.249 ±0.02 3.101 ±0.01 0.498 ±0.00 0.509 ±0.01
#6225 26.901 ±1.81 13.973 ±0.06 12.947 ±0.01 13.743 ±0.10 2.786 ±0.04 2.789 ±0.04 2.416 ±0.01 8.811 ±0.08 2.338 ±0.02 3.209 ±0.01 0.359 ±0.01 0.379 ±0.00

@nlf
Copy link
Contributor

nlf commented Mar 16, 2023

@npm-cli-bot benchmark this

@wraithgar wraithgar marked this pull request as ready for review March 30, 2023 20:56
@wraithgar wraithgar requested a review from a team as a code owner March 30, 2023 20:56
@wraithgar wraithgar requested review from nlf and removed request for a team March 30, 2023 20:56
@wraithgar
Copy link
Member Author

@npm-cli-bot benchmark this

@wraithgar wraithgar merged commit 82879f6 into latest Apr 18, 2023
@wraithgar wraithgar deleted the gar/lazy branch April 18, 2023 17:12
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants