Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

deps: upgrade npm to 9.6.6 #47862

Merged
merged 1 commit into from
May 7, 2023
Merged

deps: upgrade npm to 9.6.6 #47862

merged 1 commit into from
May 7, 2023

Conversation

npm-cli-bot
Copy link
Contributor

This PR contains changes from: npm@9.6.5 npm@9.6.6

9.6.5

9.6.5 (2023-04-19)

Bug Fixes

Documentation

Dependencies

9.6.6

9.6.6 (2023-05-03)

Dependencies

@nodejs-github-bot nodejs-github-bot added fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51630/

tniessen
tniessen approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 13,000 lines in a semver-patch update... 😆

@wraithgar
Copy link

Adding 13,000 lines in a semver-patch update... 😆

This is a valid concern and I'd like to address it.

There are some big shuffles going on in a lot of the modules that isaacs maintains. Semver-major bumps in most of them to change the export signature to make supporting types easier. This led to some necessary new duplication in the tree as not EVERY subdependency got onto the newest version.

The decision to live w/ the duplication instead of holding off on updating subdependencies was made, as the longer we go w/o updating the harder the update tends to become.

@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels May 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit b7c82a3 into nodejs:main May 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b7c82a3

targos pushed a commit that referenced this pull request May 12, 2023
@npm-cli-bot @targos
deps: upgrade npm to 9.6.6
7b2f17c 
PR-URL: #47862
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
@targos targos added the lts-watch-v18.x PRs that may need to be released in v18.x. label May 15, 2023
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@npm-cli-bot @danielleadams
deps: upgrade npm to 9.6.6
e2e1af3 
PR-URL: #47862
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@npm-cli-bot @MoLow
deps: upgrade npm to 9.6.6
b796d35 
PR-URL: nodejs#47862
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luke Karrys <luke@lukekarrys.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
@mcollina mcollina mentioned this pull request Sep 12, 2023
Open
@targos targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Oct 27, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@npm-cli-bot @nodejs-github-bot @wraithgar @lukekarrys @lpinca @tniessen @debadree25 @targos