fix: npm link does not respect --no-save #6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Oct 17, 2023
wraithgar
reviewed
Oct 30, 2023
wraithgar
reviewed
Oct 30, 2023
wraithgar
reviewed
Oct 30, 2023
|
It looks like we may be hitting coverage by accident here. I would expect a test that sets |
wraithgar
reviewed
Oct 31, 2023
Merged
This was referenced Oct 31, 2023
1 task
This was referenced Nov 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3619
there was no condition to capture no-save scenario, read that from CLI and included condition to check that which will end up not saving anything if -no-save is passed as arguments.