Skip to content

chore: replace var with const/let in repo #119

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Dec 14, 2018

@watilde watilde requested a review from a team as a code owner December 14, 2018 20:39
@watilde watilde changed the title chore: replace var with const/let chore: replace var with const/let in repo Dec 14, 2018
@zkat
Copy link
Contributor

zkat commented Dec 14, 2018

Please split this up into two PRs. I can take the docs PRs more easily than code ones, too.

@watilde
Copy link
Contributor Author

watilde commented Dec 15, 2018

I just splitted into the two here and #120.

Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@aeschright aeschright changed the base branch from latest to release-next January 9, 2019 22:06
@aeschright aeschright merged commit 73a3edf into npm:release-next Jan 9, 2019
aeschright pushed a commit that referenced this pull request Jan 10, 2019
aeschright added a commit that referenced this pull request Jan 10, 2019
aeschright pushed a commit that referenced this pull request Jan 18, 2019
@watilde watilde deleted the feature/let-const branch December 2, 2019 17:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants