-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
doc: update package.json docs to include repository.directory details #140
Merged
aeschright
merged 1 commit into
npm:release-next
from
greysteil:add-directory-details-to-repository
Jan 29, 2019
Merged
doc: update package.json docs to include repository.directory details #140
aeschright
merged 1 commit into
npm:release-next
from
greysteil:add-directory-details-to-repository
Jan 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this needs a rebase |
Yes it does! Done. |
styfle
reviewed
Jan 21, 2019
styfle
reviewed
Jan 21, 2019
felixfbecker
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
styfle
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
aeschright
reviewed
Jan 29, 2019
@aeschright - updated! Hopefully this is good to go now. 🙏 |
aeschright
pushed a commit
that referenced
this pull request
Feb 14, 2019
…#140) PR-URL: #140 Credit: @greysteil Reviewed-By: @aeschright
This was referenced Feb 18, 2019
4 tasks
mikemimik
pushed a commit
that referenced
this pull request
Dec 2, 2019
See #140 PR-URL: #163 Credit: @ybiquitous Close: #163 Reviewed-by: @mikemimik
isaacs
pushed a commit
that referenced
this pull request
Aug 4, 2020
Related: #140 PR-URL: #163 Credit: @ybiquitous Close: #163 Reviewd-By: @isaacs
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of npm/rfcs#19.