Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Set modified to undefined when not retrievable #153

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Set modified to undefined when not retrievable #153

merged 1 commit into from
Feb 18, 2019

Conversation

simonua
Copy link
Contributor

@simonua simonua commented Feb 5, 2019 •
edited
Loading

Fixes 5145.
Also fixes 20169 in the archived npm repo.

Here is a pre- and post-change screenshot:

image

@simonua simonua requested a review from a team as a code owner February 5, 2019 19:24
@simonua
Copy link
Contributor Author

simonua commented Feb 5, 2019

Not knowing much about packument.time, I assumed that it would still contain an entry for the initial version, 1.0.0, but that was not the case. Admittedly, I didn't dig very deeply here, and because there wasn't a version prior to this first publish, there couldn't be a modified date in existence, so it would be applicable to set the modified property to undefined.

@zkat zkat added the semver:patch semver patch level for changes label Feb 7, 2019
zkat
zkat approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I guess some registries just don't have the info, and I see no need to display this if the data just isn't there.

Thanks, @simonua!

@simonua
Copy link
Contributor Author

simonua commented Feb 7, 2019

Awesome! Thank you, @zkat!

@zkat zkat merged commit 414c357 into npm:release-next Feb 18, 2019
zkat pushed a commit that referenced this pull request Feb 18, 2019
@simonua @zkat
view: set modified to undefined when not retrievable (#153)
cf09fba 
PR-URL: #153
Credit: @simonua
Reviewed-By: @zkat
@simonua simonua deleted the feature/prevent-exception-in-undefined-modified-date branch February 19, 2019 00:53
@simonua
Copy link
Contributor Author

simonua commented Feb 21, 2019

I verified that the fix for this got merged and released in npm@6.9.0-next.0. Thank you!

This was referenced Feb 1, 2020
Open
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
This was referenced Sep 27, 2021
Open
Open
Open
Open
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Feb 15, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Jun 1, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Dec 19, 2023
Open
@MrBrain295 MrBrain295 mentioned this pull request Dec 19, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Dec 20, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Apr 30, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 24, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonua @zkat