Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added ARM64 platform check #195

Closed
wants to merge 1 commit into from
Closed

Added ARM64 platform check #195

wants to merge 1 commit into from

Conversation

ossdev07
Copy link
Contributor

@ossdev07 ossdev07 commented May 1, 2019

I have added the arm64 architecture check in the legacy-platform-all.js test file.

@ossdev07
CLI: Add the arm64 check for legacy-platform-all.js test case.
2cfe375 
Signed-off-by: ossdev <ossdev@puresoftware.com>
@ossdev07 ossdev07 requested a review from a team as a code owner May 1, 2019 05:38
@ossdev07
Copy link
Contributor Author

Ping @luislobo @aeschright

Please, could you look into PR and suggest if anything else is required from my side.

@rhenwood-arm
Copy link

I would be nice for me (as an AArch64 aka Arm64 user) if this small fix was landed. Is there any feedback?

@ossdev07
Copy link
Contributor Author

Hi, @luislobo @aeschright

Is there any update on the PR status?

@aeschright
Copy link
Contributor

Unfortunately, I'm no longer on the project and don't know when PRs will be merged again. Details: https://gist.github.com/aeschright/8ed09cbc2a4aee00fcb4ad35086d76a6

@ossdev07
Copy link
Contributor Author

@aeschright Thanks for letting us know.

@isaacs isaacs added the semver:patch semver patch level for changes label Jun 26, 2019
@isaacs isaacs mentioned this pull request Jul 1, 2019
Merged
@DanielRuf
Copy link

Is this already merged?

@ossdev07
Copy link
Contributor Author

ossdev07 commented Jul 9, 2019 •
edited
Loading

Thanks for accepting the PR, it got merged by the raised PR #205

@ossdev07 ossdev07 closed this Jul 9, 2019
@snyk-bot snyk-bot mentioned this pull request Aug 13, 2019
Open
@Theo13111 Theo13111 mentioned this pull request Aug 20, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Oct 19, 2023
Merged
@soloinovator soloinovator mentioned this pull request Feb 11, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 11, 2024
Open
@311821105 311821105 mentioned this pull request Feb 11, 2024
Open
@mtdev2 mtdev2 mentioned this pull request Feb 11, 2024
Open
@311821105 311821105 mentioned this pull request Feb 11, 2024
Open
@CALISOULB CALISOULB mentioned this pull request Feb 11, 2024
Open
This was referenced Feb 11, 2024
Open
Open
@hojatA1 hojatA1 mentioned this pull request Feb 11, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 11, 2024
Open
@kingjay66 kingjay66 mentioned this pull request Feb 11, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 11, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 11, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 11, 2024
Open
This was referenced Feb 11, 2024
Open
Open
@Billywildhig Billywildhig mentioned this pull request Feb 12, 2024
Open
@kevinjm39 kevinjm39 mentioned this pull request Feb 12, 2024
Open
@311821105 311821105 mentioned this pull request Feb 12, 2024
Open
@LadyK-21 LadyK-21 mentioned this pull request Feb 12, 2024
Open
This was referenced Feb 12, 2024
Open
Open
This was referenced Feb 12, 2024
Open
Open
@kingjay66 kingjay66 mentioned this pull request Feb 12, 2024
Open
@adamlaska adamlaska mentioned this pull request Feb 12, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 12, 2024
Open
This was referenced Feb 12, 2024
Open
Open
Open
This was referenced Feb 12, 2024
Open
Open
Open
@jackromo888 jackromo888 mentioned this pull request Feb 12, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 12, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 12, 2024
Open
@soloinovator soloinovator mentioned this pull request Feb 12, 2024
Open
@TheManager73 TheManager73 mentioned this pull request Feb 12, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Apr 30, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 24, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ossdev07 @rhenwood-arm @aeschright @DanielRuf @isaacs