tests: parallel tests #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #165 Credit: @ljharb Reviewed-By: @zkat Reviewed-By: @aeschright
PR-URL: #175 Fixes: https://npm.community/t/npm-token-create-doesnt-work-in-6-6-0-6-9-0/6259 Credit: @zkat Reviewed-By: @aeschright
isaacs
force-pushed
the
isaacs/parallel-tests
branch
from
24aac4e to
f1383f9
Compare
This fixes a ERR_INVALID_OPT_VALUE error on Node v12
Several changes to the test suite to support running tests in parallel, bringing the overall test time down considerably. - Replace all literal 1337 and 1234 ports with a custom per-process port assignment based on the TAP_CHILD_ID environment variable. - Add common.pkg as a per-test working directory instead of polluting __dirname or accidentally reusing the same working directory for multiple tests. - Rework test config handling so that tests don't rely on config setup being run in a particular order. - Remove the npm-registry-couchapp tests, since it (a) relies on CouchDB, (b) is no longer a reliable indicator of registry compatibility, and (c) is already superceded in most cases by tests that use npm-registry-mock. (A test suite that runs against a reference implementation is a thing that should exist, but not here.) - Remove the fake-registry logging when TAP_CHILD_ID is set, since this is extremely hard to make sense of when running multiple tests in parallel. When Node v6 compatibility is dropped in npm v7, we can upgrade to the latest version of tap for a bit more speed, dropping Domains (and the associated deprecation warnings), and a fancier test reporter.
isaacs
force-pushed
the
isaacs/parallel-tests
branch
from
f1383f9 to
bec8272
Compare
|
In next release. |
isaacs
added
semver:major
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes to the test suite to support running tests in parallel,
bringing the overall test time down considerably.
assignment based on the TAP_CHILD_ID environment variable.
__dirname or accidentally reusing the same working directory for
multiple tests.
being run in a particular order.
CouchDB, (b) is no longer a reliable indicator of registry
compatibility, and (c) is already superceded in most cases by tests
that use npm-registry-mock. (A test suite that runs against a
reference implementation is a thing that should exist, but not here.)
is extremely hard to make sense of when running multiple tests in
parallel.
When Node v6 compatibility is dropped in npm v7, we can upgrade to the
latest version of tap for a bit more speed, dropping Domains (and the
associated deprecation warnings), and a fancier test reporter.
(The readable-stream update fixes a crash on Node v12. It is separate from the main purpose of this PR, but it was annoying to keep dealing with, and probably a good idea anyway.)