Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option to disable pretty-print of package-lock.json #248

Closed
wants to merge 5 commits into from

Conversation

bl00mber
Copy link
Contributor

@bl00mber bl00mber commented Sep 9, 2019

@bl00mber bl00mber requested a review from a team as a code owner September 9, 2019 21:06
@isaacs
Copy link
Contributor

isaacs commented Sep 9, 2019

Needs a test. And it's probably fine to just use one config value for both?

Otherwise LGTM, once the linter agrees.

@isaacs isaacs added needs-tests semver:minor new backwards-compatible feature labels Sep 9, 2019
@bl00mber bl00mber force-pushed the patch-pretty-print-2 branch from b2e2fa4 to 5b2a192 Compare September 12, 2019 06:11
@bl00mber bl00mber force-pushed the patch-pretty-print-2 branch from 5b2a192 to 89262af Compare September 12, 2019 06:13
@bl00mber
Copy link
Contributor Author

During testing, I found out that stringify-package does not accept indent value 0 due to the lack of strict comparison. I've created a PR to stringify-package, if that PR will be accepted this PR will work.

@bl00mber
Copy link
Contributor Author

Also I discovered that in function lib/shrinkwrap.js : checkPackageFile files package-lock.json and npm-shrinkwrap.json were processed using name package.json and package.json itself was processed (stringified) in function lib/install/save.js : savePackageJson so I removed condition (name === PKGLOCK || name === SHRINKWRAP).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants