Fix regression in lockfile repair for sub-dependencies #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
changed the title
|
@mikemimik thanks for the merge & release! 🙇 |
This was referenced Nov 7, 2019
This was referenced Nov 25, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 14, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where lockfiles with missing sub-dependencies
are no longer repaired. The regression was introduced in this commit:
1fafb51 which in turn was bringing back
the change from this commit 24acc9f.
Changing
loadedhas caused a lot of churn so not sure if this will cause further regressions, but looks like each regression was tested.I also couldn't get the mock registry to work as the test would just hang indefinitely when trying to initialise it with
mr({ port: common.port }, function (er, s) {.... Would love any help refactoring the current tests to use the mock registry/how to set it up locally.