Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(install): ignore auditLevel #2929

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

wraithgar
Copy link
Member

npm install should not be affected by the auditLevel config, as the
results of audit do not change its exit status.

References

Closes #2715

@wraithgar wraithgar requested a review from a team as a code owner March 23, 2021 22:50
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay ty

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels Mar 24, 2021
`npm install` should not be affected by the `auditLevel` config, as the
results of audit do not change its exit status.

PR-URL: #2929
Credit: @wraithgar
Close: #2929
Reviewed-by: @ljharb, @ruyadorno
@wraithgar wraithgar merged commit 0379eab into release-next Mar 24, 2021
@wraithgar wraithgar mentioned this pull request Mar 24, 2021
@wraithgar wraithgar deleted the gar/install-audit-level branch May 6, 2021 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants