-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(install): ignore auditLevel #2929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay ty
ruyadorno
approved these changes
Mar 24, 2021
darcyclarke
added
Release 7.x
work is associated with a specific npm 7 release
semver:patch
semver patch level for changes
labels
Mar 24, 2021
`npm install` should not be affected by the `auditLevel` config, as the results of audit do not change its exit status. PR-URL: #2929 Credit: @wraithgar Close: #2929 Reviewed-by: @ljharb, @ruyadorno
wraithgar
force-pushed
the
gar/install-audit-level
branch
from
March 24, 2021 17:26
1200a1f
to
0379eab
Compare
Merged
This was referenced Nov 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Release 7.x
work is associated with a specific npm 7 release
semver:patch
semver patch level for changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm install
should not be affected by theauditLevel
config, as theresults of audit do not change its exit status.
References
Closes #2715