fix(arborist): check if a spec is a workspace before fetching a manifest, closes #3637 #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This was referenced Feb 7, 2022
Merged
16 tasks
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
Apr 6, 2023
This workflow was failing whenever there was a minor release to wrangler and a patch release to a package that depended upon wrangler. It was caused by a bug in npm that was resolved in v8.5.0. See npm/cli#4379 and npm/cli#4371. The error looks like: `No matching version found for wrangler@^2.15.0.`
petebacondarwin
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Apr 6, 2023
This workflow was failing whenever there was a minor release to wrangler and a patch release to a package that depended upon wrangler. It was caused by a bug in npm that was resolved in v8.5.0. See npm/cli#4379 and npm/cli#4371. The error looks like: `No matching version found for wrangler@^2.15.0.`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we call
_nodeFromSpecif the spec's name is also the name of a workspace, and that workspace satisfies the edge we're calling_nodeFromSpecfor, then return the workspace node instead of attempting to fetch a manifest and build a new node from that.