Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(docs): fix styling issues on docs website #453

Closed
wants to merge 10 commits into from

Conversation

claudiahdz
Copy link
Contributor

@claudiahdz claudiahdz commented Nov 8, 2019

This PR includes several minor changes to the docs website:

  • Links on docs were properly formatted on all markdown files (to allow complete offline mode interaction)
  • Links were fixed to relative paths
  • Allow UI state of the Sidebar (closing and opening sections on it)
  • Unix codes back on mandocs
  • New test and updated docs to reflect changes in registry teams API (@nomadtechie)
  • Change chmod on markdown files back to 644

Includes

@ruyadorno
Copy link
Contributor

@claudiahdz it looks like the markdown files got their file mode changed to 0755 in the docs migration PR which I believe was unintentional, if that's the case I guess we could also reinstate the original file mode here

thanks @addaleax who found out about it ❤️

.gitignore Outdated Show resolved Hide resolved
claudiahdz and others added 4 commits November 11, 2019 21:27
chore(docs): fix styling issues on man and html docs

chore(docs): fix absolute links on cli docs
2427 bytes -> 2045 bytes

PR-URL: #463
Credit: @XhmikosR
Close: #463
Reviewed-by: @claudiahdz
…stry teams API. The default developers team can not longer be removed

PR-URL: #457
Credit: @nomadtechie
Close: #457
Reviewed-by: @claudiahdz
Copy link
Contributor

@mikemimik mikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
lgtm-cheers

* b) a gzipped tarball containing (a)
* c) a url that resolves to (b)
* d) a `<name>@<version>` that is published on the registry (see [`npm-registry`](npm-registry)) with (c)
* e) a `<name>@<tag>` (see [`npm-dist-tag`](npm-dist-tag)) that points to (d)
* d) a `<name>@<version>` that is published on the registry (see [`npm-registry`](/using-npm/registry)) with (c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove - from "npm-registry"

docs/src/components/scripts.js Show resolved Hide resolved
@claudiahdz claudiahdz added Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Nov 12, 2019
claudiahdz and others added 2 commits November 13, 2019 16:08
chore(docs): change chmod markdown files

chore(docs): update gitignore
claudiahdz added a commit that referenced this pull request Nov 13, 2019
claudiahdz added a commit that referenced this pull request Nov 13, 2019
claudiahdz added a commit that referenced this pull request Nov 13, 2019
claudiahdz added a commit that referenced this pull request Nov 13, 2019
@claudiahdz claudiahdz mentioned this pull request Nov 18, 2019
@claudiahdz claudiahdz deleted the docs/styling-fixes branch December 11, 2019 15:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants