shrinkwrap: no need to read package.json when read shrinkwrap #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
suggested changes
Nov 20, 2019
lib/install/read-shrinkwrap.js
Outdated
| @@ -31,7 +31,7 @@ function readShrinkwrap (child, next) { | |||
| } | |||
| child.package._shrinkwrap = parsed | |||
| } | |||
| ).then(() => next(), next) | |||
There was a problem hiding this comment.
This is a functional change outside the scope of the intent of this PR. It means that a return value will be passed to the next function as the first argument, which would be interpreted as an error. Currently, no return value is being provided, but it makes the code more brittle.
There was a problem hiding this comment.
Yep, I would undo this change.
no need to read package.json when read shrinkwrap.
avoid to read package.json when read shrinkwrap.
|
This looks good to me now. We'll review it for the next 6.x release. Thanks! |
isaacs
approved these changes
Nov 21, 2019
mikemimik
added
semver:patch
This was referenced Dec 12, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 10, 2020
This was referenced Mar 19, 2020
This was referenced Mar 20, 2020
This was referenced Apr 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes a simple change that removes the unnecessary operation when readShrinkwrap.
This change will optimize performance when
npm install.