Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: improve quoting for run-script arguments #52

Closed
wants to merge 1 commit into from
Closed

fix: improve quoting for run-script arguments #52

wants to merge 1 commit into from

Conversation

rhendric
Copy link
Contributor

Importing from npm/npm#18709, where there is a longish conversation about breaking changes and wanting this behavior in npm ‘eventually’... npm@7 now?

@rhendric rhendric requested a review from a team as a code owner August 16, 2018 03:58
@zkat zkat added the semver:major backwards-incompatible breaking changes label Aug 20, 2018
zkat
zkat approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisional 👍 until npm@7 rolls around, since we did approve this for the last round and missed the npm@6 boat. Sorry!

@darcyclarke darcyclarke added the Release 7.x work is associated with a specific npm 7 release label Nov 19, 2019
@isaacs isaacs mentioned this pull request Sep 11, 2020
Closed
@isaacs
Copy link
Contributor

isaacs commented Sep 11, 2020

npm/run-script#3

@isaacs isaacs closed this Sep 11, 2020
@pomgui pomgui mentioned this pull request Sep 29, 2020
Closed
@lydell lydell mentioned this pull request May 18, 2021
Closed
@kevinjm39 kevinjm39 mentioned this pull request May 1, 2022
Open
@hojatA1 hojatA1 mentioned this pull request Jun 23, 2023
Open
@EMWickd EMWickd mentioned this pull request Jun 24, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Nov 30, 2023
Open
@varmakarthik12 varmakarthik12 mentioned this pull request Nov 30, 2023
Open
@MrBrain295 MrBrain295 mentioned this pull request Dec 19, 2023
Open
@CALISOULB CALISOULB mentioned this pull request Dec 20, 2023
Open
@gutwrinch gutwrinch mentioned this pull request Jan 6, 2024
Open
@Kingcrypto38 Kingcrypto38 mentioned this pull request Jan 11, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees

@isaacs isaacs

Labels
Release 7.x work is associated with a specific npm 7 release semver:major backwards-incompatible breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhendric @isaacs @zkat @darcyclarke