docs(dependency-selectors): fix Arborist example in docs #5328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-west
changed the title
kyle-west
commented
Aug 19, 2022
kyle-west
commented
Aug 19, 2022
lukekarrys
changed the title
lukekarrys
approved these changes
Aug 24, 2022
Merged
This was referenced Sep 7, 2022
This was referenced Sep 15, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arborist.loadActualis an async function. The docs show it as a callback pattern. Also,await's were being used without being inside an async function. This change fixes those examples.References
Mirrored in npm/documentation#178