Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add --install-strategy=hoisted|nested|shallow, remove --global-style, --legacy-bundling #5709

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Oct 18, 2022

  • feat: add --install-strategy config, replace --global-style with "shallow" style
  • feat: replace --legacy-bundling with --install-strategy=nested

BREAKING CHANGE:

  • removed --global-style and --legacy-bundling
  • --global now sets --install-strategy=shallow

"shallow" style

BREAKING CHANGE: remove --global-style, --global now sets
--install-strategy=shallow
@fritzy fritzy requested a review from a team as a code owner October 18, 2022 08:21
BREAKING CHANGE: removed --legacy-bundling config
@fritzy
Copy link
Contributor Author

fritzy commented Oct 18, 2022

@lukekarrys This can probably be squashed, since I had to readd the deprecated fields in a 3rd commit.

@lukekarrys lukekarrys merged commit 1574c33 into latest Oct 18, 2022
@lukekarrys lukekarrys deleted the fritzy/map-legacy-config branch October 18, 2022 22:47
lukekarrys pushed a commit that referenced this pull request Oct 19, 2022
…al-style, --legacy-bundling (#5709)

BREAKING CHANGE: deprecate boolean install flags in favor of `--install-strategy`
* deprecate --global-style, --global now sets --install-strategy=shallow
* deprecate --legacy-bundling, now sets --install-strategy=nested
jrabinow added a commit to jrabinow/dotfiles that referenced this pull request Jan 8, 2023
@devinrhode2
Copy link

For anyone crawling release notes, looking for docs on --install-strategy, they are here:
https://docs.npmjs.com/cli/v9/commands/npm-install#install-strategy

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants