Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: refuse to set deprecated/invalid config #5719

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

wraithgar
Copy link
Member

BREAKING CHANGE: npm config set will no longer accept deprecated or
invalid config options.

@wraithgar wraithgar requested a review from a team as a code owner October 19, 2022 15:05
@wraithgar
Copy link
Member Author

Closes npm/statusboard#535

@wraithgar wraithgar force-pushed the gar/npm-config-deprecated branch 2 times, most recently from 33a7ddc to 146f0f8 Compare October 19, 2022 15:33
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Oct 19, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.999 ±1.23 21.966 ±0.48 19.671 ±0.01 22.739 ±1.03 3.555 ±0.08 3.636 ±0.04 2.815 ±0.01 13.708 ±0.25 2.884 ±0.07 4.254 ±0.12
#5719 42.905 ±1.11 21.112 ±0.27 19.516 ±0.00 22.694 ±1.24 3.560 ±0.12 3.519 ±0.02 2.814 ±0.03 13.562 ±0.29 2.818 ±0.01 4.413 ±0.47
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 32.430 ±2.71 17.061 ±0.31 15.401 ±0.17 16.660 ±0.73 3.323 ±0.03 3.249 ±0.00 2.975 ±0.11 10.460 ±0.00 2.727 ±0.07 3.716 ±0.00
#5719 31.541 ±1.33 16.676 ±0.21 15.211 ±0.25 16.452 ±0.51 3.275 ±0.03 3.318 ±0.04 2.831 ±0.01 10.432 ±0.04 2.699 ±0.02 3.623 ±0.03

@wraithgar wraithgar force-pushed the gar/npm-config-deprecated branch from 146f0f8 to 4b87362 Compare October 19, 2022 15:53
BREAKING CHANGE: `npm config set` will no longer accept deprecated or
invalid config options.
@wraithgar wraithgar force-pushed the gar/npm-config-deprecated branch from 4b87362 to 8a17f27 Compare October 19, 2022 16:16
@lukekarrys lukekarrys merged commit 0a69db4 into latest Oct 19, 2022
@lukekarrys lukekarrys deleted the gar/npm-config-deprecated branch October 19, 2022 17:02
lukekarrys pushed a commit that referenced this pull request Oct 19, 2022
BREAKING CHANGE: `npm config set` will no longer accept deprecated or
invalid config options.
@xXAvoraXx
Copy link

npm config set msvs_version not working

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants