Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update npm audit fix message to provide more instruction #6

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

bradsk88
Copy link
Contributor

Discussed this here:
https://npm.community/t/npm-audit-fix-does-not-provide-enough-information/377/4

Before

$ npm audit fix
npm WARN npm-test No description
npm WARN npm-test No repository field.
npm WARN npm-test No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

up to date in 1.537s
fixed 0 of 12 vulnerabilities in 396 scanned packages
  1 package update for 12 vulns involved breaking changes
  (use `npm audit fix --force` to install breaking changes; or do it by hand)

After

$ npm audit fix
npm WARN npm-test No description
npm WARN npm-test No repository field.
npm WARN npm-test No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

up to date in 1.547s
fixed 0 of 12 vulnerabilities in 396 scanned packages
  1 package update for 12 vulns involved breaking changes
  (use `npm audit fix --force` to install breaking changes; or refer to `npm audit` for steps to fix these manually)

@bradsk88 bradsk88 requested a review from a team as a code owner July 11, 2018 01:07
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for putting together the PR! 👍 🐑 🚀 💥

@zkat zkat changed the base branch from latest to release-next July 13, 2018 17:36
@zkat zkat force-pushed the release-next branch 2 times, most recently from 614c234 to 322d9c2 Compare July 13, 2018 17:46
@zkat zkat merged commit c1dad1e into npm:release-next Jul 14, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants