Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(view): refactor exec and execWorkspaces to call same methods #7520

Merged
merged 1 commit into from
May 14, 2024

Conversation

lukekarrys
Copy link
Contributor

Also cleanup json mode to not stringify and parse unnecessarily

@lukekarrys lukekarrys requested a review from a team as a code owner May 13, 2024 21:23
Also cleanup `json` mode to not stringify and parse unnecessarily
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 13, 2024

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 33.479 ±1.23 10.645 ±0.03 11.802 ±0.16 1.555 ±0.03 1.550 ±0.01 1.295 ±0.00 8.250 ±0.02 1.281 ±0.01 0.139 ±0.00 0.167 ±0.00 13.512 ±0.18 3.920 ±2.63
#7520 32.625 ±0.55 10.647 ±0.01 11.727 ±0.02 1.555 ±0.01 1.555 ±0.02 1.270 ±0.00 8.238 ±0.05 1.282 ±0.01 0.138 ±0.00 0.167 ±0.00 14.867 ±0.05 2.247 ±0.20
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 26.238 ±2.47 7.963 ±0.00 8.941 ±0.08 1.531 ±0.01 1.507 ±0.01 1.435 ±0.03 5.846 ±0.02 1.325 ±0.01 0.140 ±0.00 0.167 ±0.00 9.515 ±0.15 3.139 ±1.63
#7520 25.652 ±0.88 7.976 ±0.02 8.938 ±0.00 1.536 ±0.01 1.538 ±0.02 1.435 ±0.01 6.001 ±0.00 1.354 ±0.01 0.147 ±0.00 0.175 ±0.00 10.181 ±0.31 2.021 ±0.05

@lukekarrys lukekarrys merged commit 76aef74 into latest May 14, 2024
23 checks passed
@lukekarrys lukekarrys deleted the lk/view-refactor branch May 14, 2024 14:34
@github-actions github-actions bot mentioned this pull request May 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants