Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: send proper otp token on web auth #7545

Merged
merged 1 commit into from
May 20, 2024
Merged

fix: send proper otp token on web auth #7545

merged 1 commit into from
May 20, 2024

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner May 20, 2024 17:36
Copy link
Contributor

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was this a recent regression?

@wraithgar
Copy link
Member Author

@hashtagchris yes three weeks ago a lot of this otp code was consolidated and this one field was missed.

@wraithgar wraithgar merged commit 9e6686b into latest May 20, 2024
23 checks passed
@wraithgar wraithgar deleted the gar/deprecate-otp branch May 20, 2024 17:55
@github-actions github-actions bot mentioned this pull request May 20, 2024
@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 28.751 ±0.48 11.029 ±0.06 12.029 ±0.10 1.579 ±0.01 1.587 ±0.00 1.309 ±0.00 8.434 ±0.01 1.300 ±0.00 0.143 ±0.00 0.172 ±0.00 15.172 ±0.11 2.185 ±0.11
#7545 28.938 ±0.24 11.067 ±0.04 12.041 ±0.06 1.628 ±0.07 1.580 ±0.02 1.296 ±0.00 8.478 ±0.09 1.320 ±0.02 0.143 ±0.00 0.168 ±0.00 15.089 ±0.13 2.229 ±0.17
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 22.457 ±0.04 8.237 ±0.05 9.113 ±0.04 1.534 ±0.01 1.528 ±0.02 1.416 ±0.01 5.953 ±0.03 1.347 ±0.01 0.141 ±0.00 0.170 ±0.00 10.143 ±0.03 1.987 ±0.01
#7545 22.087 ±0.16 8.203 ±0.00 9.019 ±0.02 1.537 ±0.02 1.530 ±0.01 1.420 ±0.00 5.941 ±0.03 1.344 ±0.02 0.140 ±0.00 0.172 ±0.00 10.079 ±0.05 2.023 ±0.02

@Cachond1

This comment was marked as spam.

@clickwithclark
Copy link

clickwithclark commented May 28, 2024

can confirm "otp" fails because ["otp" with value "[object Object]" fails to match the required pattern: /^\d+$/, "otp" length must be 64 characters long] is still a bug on 10.8.0 as of today, downgrading with npm i -g npm@10.7.0 I was able to get my package published, mentioning it here as this issue was quoted as it being fixed wit this pr.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants