Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(search): properly display multiple search terms #7980

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Dec 13, 2024

When searching for multiple terms in npm, the highlighting code has a bug where it duplicates the output any time there are matching terms. This fixes the highlighting code.

Before:
output of "npm search gar promisify" showing the name being duplicated

After:
output of "node . search gar promisify" showing the name being displayed correctly

@wraithgar wraithgar requested a review from a team as a code owner December 13, 2024 16:05
@wraithgar wraithgar force-pushed the gar/search-multi-terms branch from fa2ba86 to a821cd2 Compare December 13, 2024 16:06
@wraithgar wraithgar force-pushed the gar/search-multi-terms branch from a821cd2 to 0c88565 Compare December 13, 2024 16:11
Copy link

@Tayvon Tayvon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wraithgar wraithgar merged commit f7da341 into latest Dec 16, 2024
19 checks passed
@wraithgar wraithgar deleted the gar/search-multi-terms branch December 16, 2024 18:12
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants