Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix generated shell scripts for MSYS2/MINGW #30

Closed
wants to merge 1 commit into from

Commits on Jun 21, 2018

  1. Fix generated shell scripts for MSYS2/MINGW

    It has been reported tons and tons of times that the generated shell
    scripts simply fail in Git Bash of the Git for Windows project. The
    reason is that the Cygwin-specific basedir workaround is also required
    for MSYS2 (which is used internally by the Git Bash).
    
    Let's be nice to everybody and include support for MSYS2.
    
    As MSYS2 distinguishes between MSYS/MINGW modes, triggered by setting
    the environment variable MSYSTEM to the values MSYS, MINGW32 and
    MINGW64, and as those modes are reflected in the output of `uname -s`,
    we need to look not only for MSYS but also for MINGW in the output of
    `uname`.
    
    This addresses yarnpkg/yarn#5349 among other
    issues.
    
    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    dscho committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    df23827 View commit details
    Browse the repository at this point in the history