Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BUG] GIT_SSH_COMMAND should honor GIT_SSH #129

Closed
1 task done
mvorisek opened this issue Apr 14, 2023 · 3 comments
Closed
1 task done

[BUG] GIT_SSH_COMMAND should honor GIT_SSH #129

mvorisek opened this issue Apr 14, 2023 · 3 comments
Labels
Needs Triage needs an initial review

Comments

@mvorisek
Copy link

mvorisek commented Apr 14, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently GIT_SSH_COMMAND has hardcoded ssh path in https://github.com/npm/git/blob/v4.0.4/lib/opts.js#L5

But there is also GIT_SSH env. var honored by standard git. The GIT_SSH_COMMAND should use GIT_SSH (and quoted) instead of ssh when GIT_SSH is non-empty.

Will fix npm/cli#2891 as I can confirm npm/cli#2891 (comment) fixes the problem.

image

Expected Behavior

GIT_SSH other than ssh/empty is honored.
@mvorisek mvorisek added the Needs Triage needs an initial review label Apr 14, 2023
@dennishenry dennishenry mentioned this issue Jun 21, 2024
Merged
@dennishenry
Copy link
Contributor

Opened a PR to offer to resolve this: #194

wraithgar pushed a commit that referenced this issue Jul 9, 2024
@dennishenry
fix: smarter git ssh override (#194)
2135513 
npm will no longer manually set `GIT_ASKPASS` or `GIT_SSH_COMMAND` if it finds those values already defined in the user's git config.

## References

npm/cli#2891
#193
#129

---------

Co-authored-by: pacotedev <i+pacotedev@izs.me>
@dennishenry
Copy link
Contributor

This issue is now resolved in npm version 10.8.2 which has my PR above in it: https://github.com/npm/cli/releases/tag/v10.8.2

@wraithgar I think this can be closed now

@mvorisek
Copy link
Author

Sure and thank you ❤

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvorisek @dennishenry