Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: #61 & #65 to revert breaking changes for node 6 #66

Closed

Conversation

darcyclarke
Copy link
Contributor

@darcyclarke darcyclarke commented Feb 29, 2020

  • Changed const to var
  • Rewrote tests to be conditional of url.URL support
  • Updated --coverage threshold to "90" as we can't fully test in node 6 based on the url.URL implementation

@darcyclarke darcyclarke force-pushed the darcyclarke/fix-61-65-node-6-support branch from f24575d to 5b192c8 Compare February 29, 2020 21:49
@Marcinbyku
Copy link

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants