Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

deps: uninstall lru-cache #709

Merged
merged 1 commit into from
May 4, 2024
Merged

deps: uninstall lru-cache #709

merged 1 commit into from
May 4, 2024

Conversation

SuperchupuDev
Copy link
Contributor

#704 removed usage of lru-cache, but the dependency wasn't removed from package.json

References

Related to #704

@SuperchupuDev SuperchupuDev requested a review from a team as a code owner May 4, 2024 20:34
@SuperchupuDev SuperchupuDev changed the title remove unused lru-cache dependency deps: uninstall lru-cache May 4, 2024
@lukekarrys lukekarrys merged commit 988a8de into npm:main May 4, 2024
29 checks passed
@github-actions github-actions bot mentioned this pull request May 4, 2024
@SuperchupuDev SuperchupuDev deleted the deps/remove-lru-cache branch May 4, 2024 21:04
@wraithgar
Copy link
Member

wraithgar commented May 5, 2024

I'm really confused what happened here. 3fabe4d very much did remove this dep.

@wraithgar
Copy link
Member

Oh I see what happened, the commit I pulled from the other PR put it back cause of merge conflict shenanigans. Thanks for catching this.

wraithgar pushed a commit that referenced this pull request May 7, 2024
🤖 I have created a release *beep* *boop*
---


## [7.6.1](v7.6.0...v7.6.1)
(2024-05-04)

### Bug Fixes

*
[`c570a34`](c570a34)
[#704](#704) linting:
no-unused-vars (@wraithgar)
*
[`ad8ff11`](ad8ff11)
[#704](#704) use internal cache
implementation (@mbtools)
*
[`ac9b357`](ac9b357)
[#682](#682) typo in compareBuild
debug message (#682) (@mbtools)

### Dependencies

*
[`988a8de`](988a8de)
[#709](#709) uninstall
`lru-cache` (#709)
*
[`3fabe4d`](3fabe4d)
[#704](#704) remove lru-cache

### Chores

*
[`dd09b60`](dd09b60)
[#705](#705) bump
@npmcli/template-oss to 4.22.0 (@lukekarrys)
*
[`ec49cdc`](ec49cdc)
[#701](#701) chore: chore:
postinstall for dependabot template-oss PR (@lukekarrys)
*
[`b236c3d`](b236c3d)
[#696](#696) add benchmarks
(#696) (@H4ad)
*
[`692451b`](692451b)
[#688](#688) various improvements
to README (#688) (@mbtools)
*
[`5feeb7f`](5feeb7f)
[#705](#705) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`074156f`](074156f)
[#701](#701) bump
@npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants