fix: throws an err when alias is without name (#184)

throws error when alias spec is without name. e.g. ( foo@npm: ) Fixes: npm/cli#7590
npm · Jul 22, 2024 · 59d53b3 · 59d53b3
1 parent 74d06ae
commit 59d53b3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/npa.js b/lib/npa.js
@@ -380,6 +380,10 @@ function fromAlias (res, where) {
     throw new Error('aliases only work for registry deps')
   }
 
+  if (!subSpec.name) {
+    throw new Error('aliases must have a name')
+  }
+
   res.subSpec = subSpec
   res.registry = true
   res.type = 'alias'

diff --git a/test/basic.js b/test/basic.js
@@ -692,6 +692,10 @@ t.test('basic', function (t) {
     npa('foo@npm:bar@npm:baz')
   }, 'nested aliases not supported')
 
+  t.throws(() => {
+    npa('foo@npm:')
+  }, 'aliases must have a name')
+
   t.throws(() => {
     npa('foo@npm:foo/bar')
   }, 'aliases only work for registry deps')