Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
RFC: npm workspaces - Working with workspaces #117
RFC: npm workspaces - Working with workspaces #117
Changes from 1 commit
a9ce7f0
979b995
8a767a0
cb9ca14
d207867
0c90e3f
8167fa9
4ab99e9
767407b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would highly suggest a number of different options to configure the parallelization of
run
across workspaces--parallel
spawn scripts across different packages in parallel processes (default to physical cores)--parallel=<count>
spawn<count>
processes (as much as possible)--parallel-nodes
split workload automatically across CI Nodes--parallel-order=dependency-graph
limit parallelization by workspace cross-dependency graph, so that scripts only run on packages once all other packages have been run (seetask-graph-runner
for example)--parallel-order=any
Run scripts on packages in any orderWorkspace-based monorepos have a huge need to optimize their different scripts and these options go a huge way to solve for different use cases.
I have even more options in this package: https://github.com/jamiebuilds/workspaces-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does workspace name === subpackage name? There might be some ambiguity between directory structure and package names, so maybe, everywhere it's specified, locations should be relative paths (
./packages/loren
) and package names regular strings? This would go for CLI args as well as aliases. Either should be able to use globs in the context of aliases.