Merge 67c100c into 4b8cfe3

nre-learning · Dec 9, 2020 · 5fa186c · 5fa186c
2 parents 4b8cfe3 + 67c100c
commit 5fa186c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## In development
 
+- Convert networkpolicy to use blank namespace selector instead of RFC1918 [#205](https://github.com/nre-learning/antidote-core/pull/205)
 - Upgrade grpc-gateway and add required protobuf options [#204](https://github.com/nre-learning/antidote-core/pull/204)
 - Add (deprecated) 'legacy' image flavor [#202](https://github.com/nre-learning/antidote-core/pull/202)
 - Move networkpolicy creation to the beginning of the creation of livelesson resources  [#201](https://github.com/nre-learning/antidote-core/pull/201)

diff --git a/scheduler/networks.go b/scheduler/networks.go
@@ -97,10 +97,8 @@ func (s *AntidoteScheduler) createNetworkPolicy(sc ot.SpanContext, nsName string
 
 						// Have only been able to get this working with this CIDR.
 						// Tried a /32 directly to the svc IP for DNS, but that didn't seem to work.
-						// Should revisit this later. Open to all RFC1918 for now.
-						{IPBlock: &netv1.IPBlock{CIDR: "10.0.0.0/8"}},
-						{IPBlock: &netv1.IPBlock{CIDR: "192.168.0.0/16"}},
-						{IPBlock: &netv1.IPBlock{CIDR: "171.16.0.0/12"}},
+						// Should revisit this later. Open to all cluster namespaces for now.
+						{NamespaceSelector: &meta_v1.LabelSelector{}},
 					},
 					Ports: []netv1.NetworkPolicyPort{
 						{Protocol: &tcp, Port: &fivethree},