This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Support option to specify curriculum version #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 26.82% 26.75% -0.07%
==========================================
Files 20 20
Lines 2032 2037 +5
==========================================
Hits 545 545
- Misses 1437 1441 +4
- Partials 50 51 +1
Continue to review full report at Codecov.
|
This was referenced Jul 30, 2019
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're now releasing the curriculum separately from the platform, we're also taking the opportunity to build and tag all curriculum images for each release. As a result, it is necessary to be able to specify which version of the curriculum Syringe is loading, so that it can be sure to request the correct tag for all endpoint versions.
This PR does this by adding an environment variable to Syringe called
SYRINGE_CURRICULUM_VERSION, which defaults tolatest, but in production, should be set to the exact tag used for curriculum releases, and associated curriculum image build tags.