Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Disable TSDB by default (configurable) #130

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Aug 16, 2019

There was a variable in config.go for a while that was supposed to get plumbed into an environment variable, but I haven't gotten around to it until now. We don't want TSDB exports to be enabled by default, because the error messages that come up when it fails to connect (which is totally normal unless you bother setting one up - not common for selfmedicate users) are alarming if you don't know what they mean.

So, this should take care of it - exporting to influxdb is off by default, and must be explicitly enabled.

Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #130 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   31.74%   31.74%   +<.01%     
==========================================
  Files          20       20              
  Lines        2054     2060       +6     
==========================================
+ Hits          652      654       +2     
- Misses       1337     1340       +3     
- Partials       65       66       +1
Impacted Files Coverage Δ
api/exp/resulthandlers.go 9.67% <0%> (-0.33%) ⬇️
api/exp/server.go 4.1% <0%> (-0.03%) ⬇️
config/config.go 61.45% <60%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcada4e...6be5048. Read the comment docs.

@Mierdin Mierdin merged commit a872371 into master Sep 19, 2019
@Mierdin Mierdin deleted the disable-tsdb-default branch September 19, 2019 05:05
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant