This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Fix collection slug type in API model #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <matt@oswalt.dev>
Signed-off-by: Matt Oswalt <matt@oswalt.dev>
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 26.11% 26.11%
=======================================
Files 24 24
Lines 2374 2374
=======================================
Hits 620 620
Misses 1692 1692
Partials 62 62 Continue to review full report at Codecov.
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the lesson API, collection slugs were still being defined as ints, and therefore left out of the DB->API translation function because of a type mismatch. This fixes this problem, and results in the collection slug showing up properly in a retrieved lesson, where applicable.