Finalize GitHub Actions setup

.github/workflows/go.yml

@@ -36,15 +36,21 @@ jobs:
         go mod download
         make install_bins
         go get github.com/jteeuwen/go-bindata/...
-
+      env:
+        GOPATH: /home/runner/go
+
     - name: Check changelog
       run: hack/check-changelog.sh
 
     - name: Build
       run: make
+      env:
+        GOPATH: /home/runner/go
 
     - name: Test
       run: make test
+      env:
+        GOPATH: /home/runner/go
 
     - name: call codecov
       run: bash <(curl -s https://codecov.io/bash)

CHANGELOG.md

@@ -6,6 +6,7 @@
 - Move to Go Modules (finally) and fix txn functions [#191](https://github.com/nre-learning/antidote-core/pull/191)
 - Image Flavors [#189](https://github.com/nre-learning/antidote-core/pull/189)
 - Add subnet to Connections configuration [#194](https://github.com/nre-learning/antidote-core/pull/194)
+- Move to Github Actions [#195](https://github.com/nre-learning/antidote-core/pull/195/)
 
 ## v0.6.2 - May 03, 2020
 

Makefile

@@ -99,6 +99,9 @@ gengo:
 # (This is important so that we keep the version of our tools and our vendored libraries identical)
 install_bins:
 
+	echo $$GOPATH
+	ls -lha $$GOPATH
+
 	ls -lha $$GOPATH/pkg/mod/github.com/grpc-ecosystem/
 
 	@# Figure out how to make versions dynamic

scheduler/networks.go

@@ -149,8 +149,6 @@ func (s *AntidoteScheduler) createNetwork(sc ot.SpanContext, netIndex int, netNa
 		subnet = connectionSubnet
 	}
 
-	// https://github.com/containernetworking/plugins/tree/master/plugins/ipam/static
-
 	networkArgs := fmt.Sprintf(`{
 			"name": "%s",
 			"type": "bridge",
@@ -167,13 +165,6 @@ func (s *AntidoteScheduler) createNetwork(sc ot.SpanContext, netIndex int, netNa
 			}
 		}`, networkName, bridgeName, subnet)
 
-	// TODO(mierdin): consider updating multus
-
-	// TODO(mierdin): will likely want to do something here that says static if provided, but if not, just do whatever.
-	// Except if they don't have Connections, they don't have networks, so maybe not. Maybe just assuming static when using connections, this doesn't
-	// affect eth0 anyways
-	// Except in the cases of vqfx or any manually configured VM, it would be preferred to just say "please configure any subnet". Maybe both options is good after all
-
 	network := &networkcrd.NetworkAttachmentDefinition{
 		// apiVersion: "k8s.cni.cncf.io/v1",
 		ObjectMeta: meta_v1.ObjectMeta{