Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Convert networkpolicy to use blank namespace selector instead of RFC1918 #205

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Convert networkpolicy to use blank namespace selector instead of RFC1918 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
239050b
Convert networkpolicy to use blank namespace selector instead of RFC1918
Mierdin Dec 9, 2020
67c100c
update changelog
Mierdin Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## In development

- Convert networkpolicy to use blank namespace selector instead of RFC1918 [#205](https://github.com/nre-learning/antidote-core/pull/205)
- Upgrade grpc-gateway and add required protobuf options [#204](https://github.com/nre-learning/antidote-core/pull/204)
- Add (deprecated) 'legacy' image flavor [#202](https://github.com/nre-learning/antidote-core/pull/202)
- Move networkpolicy creation to the beginning of the creation of livelesson resources [#201](https://github.com/nre-learning/antidote-core/pull/201)
Expand Down
6 changes: 2 additions & 4 deletions scheduler/networks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,8 @@ func (s *AntidoteScheduler) createNetworkPolicy(sc ot.SpanContext, nsName string

// Have only been able to get this working with this CIDR.
// Tried a /32 directly to the svc IP for DNS, but that didn't seem to work.
// Should revisit this later. Open to all RFC1918 for now.
{IPBlock: &netv1.IPBlock{CIDR: "10.0.0.0/8"}},
{IPBlock: &netv1.IPBlock{CIDR: "192.168.0.0/16"}},
{IPBlock: &netv1.IPBlock{CIDR: "171.16.0.0/12"}},
// Should revisit this later. Open to all cluster namespaces for now.
{NamespaceSelector: &meta_v1.LabelSelector{}},
},
Ports: []netv1.NetworkPolicyPort{
{Protocol: &tcp, Port: &fivethree},
Expand Down