Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Add version to build info, share with syrctl #90

Merged
merged 3 commits into from
Mar 17, 2019
Merged

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Mar 17, 2019

This PR adds a "version" field to the buildinfo struct generated at compile time.

This will get set to "dev-" in most cases during development, but if the current SHA matches a git tag, it will be set to that tag. This will allow us to predictably place the correct version into both syrctl and syringed without having to manually update it from version to version.

Mierdin added 3 commits March 16, 2019 18:52
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
@codecov
Copy link

codecov bot commented Mar 17, 2019

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   23.48%   23.48%           
=======================================
  Files          18       18           
  Lines        1916     1916           
=======================================
  Hits          450      450           
  Misses       1412     1412           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23841e7...d9eece0. Read the comment docs.

@Mierdin Mierdin merged commit a5e0458 into master Mar 17, 2019
@Mierdin Mierdin deleted the build-info-version branch March 17, 2019 02:41
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant