Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Setting proper permissions on copied lesson dir, using config'd location #92

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Mar 20, 2019

For selfmedicate users, the mounted lesson directory was owned by root:root, which meant they couldn't make changes to lesson files, like they could in production, where Git is used to provide access to these resources.

This change recursively chowns the lesson directory to ensure they have this same ability when using the local copy option.

Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #92 into master will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   23.48%   23.61%   +0.13%     
==========================================
  Files          18       18              
  Lines        1916     1918       +2     
==========================================
+ Hits          450      453       +3     
  Misses       1412     1412              
+ Partials       54       53       -1
Impacted Files Coverage Δ
scheduler/scheduler.go 30.63% <0%> (-0.28%) ⬇️
scheduler/namespaces.go 58.03% <0%> (+2.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881a71b...7ce851a. Read the comment docs.

@Mierdin Mierdin merged commit da4a81b into master Mar 20, 2019
@Mierdin Mierdin deleted the copy-permissions branch March 20, 2019 04:04
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant